Fix wrong check for empty api key again -_-

UmlautAdaptarr/Controllers/CapsController.cs

@@ -18,7 +18,7 @@ namespace UmlautAdaptarr.Controllers
         [HttpGet]
         public async Task<IActionResult> Caps([FromRoute] string apiKey, [FromRoute] string domain, [FromQuery] string? apikey)
         {
-            if (_options.ApiKey != null && !apiKey.Equals(apiKey))
+            if (!string.IsNullOrEmpty(apikey) && !apiKey.Equals(apiKey))
             {
                 _logger.LogWarning("Invalid or missing API key for request.");
                 return Unauthorized("Unauthorized: Invalid or missing API key.");

UmlautAdaptarr/Controllers/SearchController.cs

@@ -169,7 +169,7 @@ namespace UmlautAdaptarr.Controllers
 
         internal bool AssureApiKey(string apiKey)
         {
-            if (options.Value.ApiKey != null && !apiKey.Equals(options.Value.ApiKey))
+            if (!string.IsNullOrEmpty(options.Value.ApiKey) && !apiKey.Equals(options.Value.ApiKey))
             {
                 logger.LogWarning("Invalid or missing API key for request.");
                 return false;

UmlautAdaptarr/Properties/launchSettings.json

@@ -3,8 +3,7 @@
     "http": {
       "commandName": "Project",
       "environmentVariables": {
-        "ASPNETCORE_ENVIRONMENT": "Development",
+        "ASPNETCORE_ENVIRONMENT": "Development"
-        "SETTINGS__ApiKey": "test123"
       },
       "_launchUrl": "optionsTODO/example.com/api?t=movie&apikey=132&imdbid=123&limit=100",
       "dotnetRunMessages": true,

UmlautAdaptarr/Services/HttpProxyService.cs

@@ -42,7 +42,7 @@ namespace UmlautAdaptarr.Services
             var bytesRead = await clientStream.ReadAsync(buffer);
             var requestString = Encoding.ASCII.GetString(buffer, 0, bytesRead);
 
-            if (_options.ApiKey != null)
+            if (!string.IsNullOrEmpty(_options.ApiKey))
             {
                 var headers = ParseHeaders(buffer, bytesRead);
 
@@ -130,7 +130,7 @@ namespace UmlautAdaptarr.Services
                 var url = _configuration["Kestrel:Endpoints:Http:Url"];
                 var port = new Uri(url).Port;
 
-                var apiKey = _options.ApiKey == null ? "_" : _options.ApiKey;
+                var apiKey = string.IsNullOrEmpty(_options.ApiKey) ? "_" : _options.ApiKey;
 
                 var modifiedUri = $"http://localhost:{port}/{apiKey}/{uri.Host}{uri.PathAndQuery}";
                 using var client = _clientFactory.CreateClient();